Skip to content

Rename functional.py to _functional.py - #306

Merged
FFY00 merged 1 commit into
python:mainfrom
encukou:_functional
Jun 26, 2024
Merged

FFY00 merged 1 commit into
python:mainfrom
encukou:_functional

Conversation

@encukou

@encukou encukou commented Mar 22, 2024

Copy link
Copy Markdown
Member

Should this module be private or should importing from importlib_resources.functional be allowed?

Your call :)

Fixes: #305

@encukou

encukou commented Mar 28, 2024

Copy link
Copy Markdown
Member Author

I plan to update the CPython PR next week, and include this rename there.

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change and giving the lack of movement on the issue an PR, I am gonna go ahead and approve it.

@FFY00
FFY00 merged commit 0058f32 into python:main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make functional module private

2 participants