Repository navigation
Add functional API - #303
Merged
Merged
Conversation
Member
Author
|
“Collateral” tests fail with: These are top-level statements (mostly |
Member
|
The diffcov tests can be ignored. I've opened #304 to track. |
jaraco
approved these changes
Mar 21, 2024
layday
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Should this module be private or should importing from importlib_resources.functional be allowed?
There was a problem hiding this comment.
(I don't recall if it was public before.)
Member
There was a problem hiding this comment.
Good call. Private is probably better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functional API, proposed for CPython here: python/cpython#116608
I tested locally using
tox, which probably doesn't match the CI checks.