Skip to content

_meta: fix SimplePath protocol #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FFY00 wants to merge 1 commit into from
Closed

_meta: fix SimplePath protocol #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions importlib_metadata/_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import os

from ._compat import Protocol
from typing import Any, Dict, Iterator, List, TypeVar, Union
from typing import Any, Dict, Iterator, List, Optional, TypeVar, Union


_T = TypeVar("_T")
Expand Down Expand Up @@ -35,14 +37,17 @@ class SimplePath(Protocol):
A minimal subset of pathlib.Path required by PathDistribution.
"""

def joinpath(self) -> 'SimplePath':
def joinpath(self, *other: Union[str, 'os.PathLike[str]']) -> 'SimplePath':
... # pragma: no cover

def __truediv__(self) -> 'SimplePath':
def __truediv__(self, other: Union[str, 'os.PathLike[str]']) -> 'SimplePath':
... # pragma: no cover

@property
def parent(self) -> 'SimplePath':
... # pragma: no cover

def read_text(self) -> str:
def read_text(
self, encoding: Optional[str] = None, errors: Optional[str] = None
) -> str:
... # pragma: no cover