Skip to content

Incomplete packages_distributions #428

Closed
#432
Closed
Incomplete packages_distributions#428
#432

Description

@FFY00
FFY00
opened on Jan 23, 2023

The search logic is very limited. I understand that we probably just wanted to keep things simple when it was added, but I want to understand if there's any plan to improve it?

importlib_metadata/importlib_metadata/__init__.py

Lines 899 to 904 in d66e35a

def _top_level_inferred(dist):
return {
f.parts[0] if len(f.parts) > 1 else f.with_suffix('').name
for f in always_iterable(dist.files)
if f.suffix == ".py"
}

In meson-python, I had to implement a more complete version of this logic. Would it make sense to port it here?

https://github.com/mesonbuild/meson-python/blob/61bb2b3315f4e312558778022ca6e87ffaed2700/mesonpy/__init__.py#L336-L359

Activity

  1. FFY00
    changed the title [-]`packages_distributions` is limited to pure-Python non-package modules[/-] [+]Incomplete `packages_distributions`[/+] on Mar 10, 2023

  2. FFY00 commented on Mar 10, 2023

    @FFY00
    FFY00
    on Mar 10, 2023
    MemberAuthor

    The current logic only returns pure Python top-level modules or package modules with at least one .py file.

  3. jaraco
    closed this as completedin #432on Mar 18, 2023
  4. jaraco
    added a commit that references this issue on Mar 18, 2023

    Merge pull request #432 from FFY00/gh-428

    66e8e9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions