Repository navigation
Broken mypy support #351
Description
Heya, after this commit: 29ec9c3,
mypy (and I imagine other static analysers) can no longer determine that the EntryPoint has name, value and group attributes.
Was there a reason for doing this:
def __init__(self, *, name, value, group):
vars(self).update(name=name, value=value, group=group)rather than the conventional
def __init__(self, *, name, value, group):
self.name = name
self.value = value
self.group = group
Activity
jaraco commentedon Sep 13, 2021
Yes. You can try making that change and you'll see the tests fail.
__setattr__is overridden to make the object immutable.I'd really like to see the mypy add support similar to
NamedTuplefor this use-case.Do you know of a way to fix this issue? I know in #342, Anders is working on enabling strict type checking on this project. But that issue is currently blocked on mypy being unable to support dynamic constructs like
always_iterableand rebasing on this recent refactor.Perhaps the reported issue here could be solved by adding type directives to the class properties, but without a repro, I'm not even sure how to test for expected behavior.
Feel free to follow up with a repro or proposed patch. In the meantime, I'll close this as answered.