Repository navigation
Add minutes for October Meeting - #205
Conversation
Documentation build overview
|
StanFromIreland
left a comment
There was a problem hiding this comment.
Can you please wrap to 80 characters, it makes reviewing far easier. I can push such a change if you prefer.
This is great! The others are so light because no one took notes (like these, which are really helpful!) and it's usually me tidying them up, occasionally even when I wasn't present (which isn't ideal). |
These changes are format or clarity focused and as such improve the meeting notes. Co-authored-by: Stan Ulbrych <stan@python.org>
|
I have to step away for a few hours, I'll take care of the indentation inconsistency and character count wrapping when I get back. Thank you so much for taking the time to review that! I wasn't sure what kind of cleaning up I should have done for the notes and that gives me a really good understanding. |
StanFromIreland
left a comment
There was a problem hiding this comment.
Sorry, a few more nits (some of which I somehow had left pending yesterday).
Co-authored-by: Stan Ulbrych <stan@python.org>
|
I'm very happy for all of these nits--they're really helpful to see the intent of the notes/how to clean it in the future. I implemented the suggested changes on the Python 3.15 release "Reports and celebrations", but I can clarify that point further because it is vague and rambly (I wrote trying to remember what I had said while also trying to jump back to notes in the next section at the same time). The sentence break did help clarify it, but I want to make sure I go further if that's what you wanted in the note on suggested change. |
StanFromIreland
left a comment
There was a problem hiding this comment.
LGTM
I fixed one more little issue (sorry for all of this, I was at a conference the last few days so things were a bit messy) adding some missing indentation.
I was verbose compared to other meeting notes. I'm not sure if it's best to trim it down or leave it as is, so I erring on the side of keeping it as is.