You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gh-1463: Added Refleak Checker Option under testing. - #1468
This pull request adds documentation for the -R flag in the python -m test command, enabling reference leak checking. This feature helps developers identify memory leaks when modifying C code.
Thank you for the addition!
When first learning about -R, you aren't likely to know what values to use for <warmups> and <repeats>. So, I think it would be good if the first paragraph, and the example, used the defaults, which are specified (somewhat unusually) with a lone colon after the -R: python -m test <test_name> -R :
A follow-up paragraph can then mention specifying <warmups> and <repeats> explicitly (which would help explain what the : is for).
Thank you for the addition! When first learning about -R, you aren't likely to know what values to use for <warmups> and <repeats>. So, I think it would be good if the first paragraph, and the example, used the defaults, which are specified (somewhat unusually) with a lone colon after the -R: python -m test <test_name> -R :
A follow-up paragraph can then mention specifying <warmups> and <repeats> explicitly (which would help explain what the : is for).
Thank you @encukou for the insight sighted out, let me work on these changes to have a more clear view of this context.
Sorry for dropping the ball here! I'll merge with a few small adjustments. Thank you for the contribution, @Lincoln-developer!
Thank you for reviewing and merging this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds documentation for the -R flag in the python -m test command, enabling reference leak checking. This feature helps developers identify memory leaks when modifying C code.
📚 Documentation preview 📚: https://cpython-devguide--1468.org.readthedocs.build/