Activity

1. littlebutt

   added a commit that references this issue on Jul 16, 2023

   gh-106799: pick another method to illustrate AC

   cf11d8d
2. erlend-aasland commented on Jul 17, 2023

   

   erlend-aasland

   on Jul 17, 2023

   Contributor

   More actions

   I think it is not proper since it cannot cover all cases and makes readers confused. A more intuitive example should be considered to replace the current one.

   Can you elaborate? Which cases are not covered, what is confusing, and what is a more intuitive example? :)
3. littlebutt commented on Jul 17, 2023

   

   littlebutt

   on Jul 17, 2023

   Author

   More actions

   I think it is not proper since it cannot cover all cases and makes readers confused. A more intuitive example should be considered to replace the current one.

   Can you elaborate? Which cases are not covered, what is confusing, and what is a more intuitive example? :)

   In the chapter Converting Your First Function, some steps don't have Sample. For example, in step 5, it says:

   (Our example docstring consists solely of a summary line, so the sample code doesn’t have to change for this step.)

   In step 9, it says:

   (_pickle.Pickler.dump has neither, so our sample is unchanged.)

   I picked another function _asyncio.Future.add_done_callback and it can cover these steps rightly. Actually, I refered this function when I was learning AC.

   👍React with 👍1Reacted by Erlend E. Aasland
4. erlend-aasland

   transferred this issue frompython/cpythonon Oct 12, 2023
5. pradyunsg

   added

   type-bugEditing of existing content neededEditing of existing content needed

   type-featureAdditions; New content or section neededAdditions; New content or section needed

   on Oct 13, 2023
6. StanFromIreland

   removed

   type-bugEditing of existing content neededEditing of existing content needed

   on Mar 3, 2026