macOS build instructions depend on Homebrew specific configuration #1059

Activity

1. erlend-aasland commented on Feb 27, 2023

   

   erlend-aasland

   on Feb 27, 2023

   ContributorAuthor

   More actions

   Blocks #1058
2. abdnafees commented on Mar 10, 2023

   

   abdnafees

   on Mar 10, 2023

   Contributor

   More actions

   I can work on this one, I am on macOS.
3. CAM-Gerlach

   assigned

   ned-deily

   and

   erlend-aasland

   on Mar 10, 2023
4. CAM-Gerlach commented on Mar 10, 2023

   

   CAM-Gerlach

   on Mar 10, 2023

   Member

   More actions

   Seems like this is pending additional analysis by @ned-deily , so I'm not sure there's anything to be done at the moment, @abdnafees ?

   👍React with 👍1Reacted by Erlend E. Aasland
5. erlend-aasland commented on Mar 10, 2023

   

   erlend-aasland

   on Mar 10, 2023

   Last edited by erlend-aasland

   ContributorAuthor

   More actions

   FTR, since it is not explicitly noted already:

   The devguide build instructions currently manipulates PKG_CONFIG_PATH, and then incorrectly assumes it is set in the subshells on the same line. Condense example, as shown by Ned in a related issue or PR (I don't have the link at hand):

   $ PKG_CONFIG_PATH="$(brew --prefix tcl-tk)/lib/pkgconfig" echo $(pkg-config --libs tcl tk)
   Package tcl was not found in the pkg-config search path.
   Perhaps you should add the directory containing `tcl.pc'
   to the PKG_CONFIG_PATH environment variable
   No package 'tcl' found
   Package tk was not found in the pkg-config search path.
   Perhaps you should add the directory containing `tk.pc'
   to the PKG_CONFIG_PATH environment variable
   No package 'tk' found

   This is not an issue right now, since Homebrew changed their behaviour (also noted by Ned). But it may be an issue if Homebrew changes their behaviour again.

   As a first step, we could inline the PGK_CONFI_PATH manipulations into the subshells. Verbose, yes, but it will be correct and safe.
6. abdnafees commented on Mar 12, 2023

   

   abdnafees

   on Mar 12, 2023

   Contributor

   More actions

   Everything went over my head.
7. CAM-Gerlach commented on Mar 13, 2023

   

   CAM-Gerlach

   on Mar 13, 2023

   Last edited by CAM-Gerlach

   Member

   More actions

   @abdnafees Given that and considering that the experts @ned-deily and @erlend-aasland have been taking care of this one, you might want to consider helping with a more accessible issue for a new contributor—there are plenty with a Help Wanted label, as well as others on the main CPython repo and others.

   👍React with 👍1Reacted by Erlend E. Aasland
8. abdnafees commented on Mar 13, 2023

   

   abdnafees

   on Mar 13, 2023

   Contributor

   More actions

   @CAM-Gerlach Thank you so much. I will check them out.
9. erlend-aasland commented on Jun 8, 2023

   

   erlend-aasland

   on Jun 8, 2023

   ContributorAuthor

   More actions

   As per the current recommendation, there's nothing to be done here anymore.
10. erlend-aasland

    closed this as not plannedon Jun 8, 2023