Skip to content

GH-98407: fix test_kill_issue43884 to not leak child processes - #98491

Merged
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:pg
Oct 24, 2022
Merged

GH-98407: fix test_kill_issue43884 to not leak child processes #98491
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:pg

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 20, 2022
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 20, 2022
@bedevere-bot

bedevere-bot commented Oct 20, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 65ed5bf 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 20, 2022
@gvanrossum gvanrossum mentioned this pull request Oct 20, 2022
Closed
gvanrossum
gvanrossum reviewed Oct 20, 2022
View reviewed changes
Comment thread Lib/test/test_asyncio/test_subprocess.py Outdated
@kumaraditya303 kumaraditya303 changed the title GH-98407: use process group in asyncio test_kill_issue43884 GH-98407: fix test_kill_issue43884 to not leak child processes Oct 23, 2022
gvanrossum
gvanrossum approved these changes Oct 24, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like confirmation from the OP (@db3l) that this indeed no longer leaves orphan processes hanging around (for more than 2 seconds :-).

@db3l

db3l commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@gvanrossum I can confirm that this PR built locally leaves no processes. I'll also watch for the regular buildbot run post-merge.

@gvanrossum
gvanrossum merged commit 3b2724a into python:main Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@kumaraditya303 @miss-islington
pythonGH-98407: fix test_kill_issue43884 to not leak child processes (
053dab5 
pythonGH-98491)

(cherry picked from commit 3b2724a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98613 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @kumaraditya303
GH-98407: fix test_kill_issue43884 to not leak child processes (GH-…
3a1eb81 
…98491)

(cherry picked from commit 3b2724a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303
kumaraditya303 deleted the pg branch October 26, 2022 16:28
@vstinner

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

I don't understand this change.

@vstinner

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

Rationale for sleep 1; sleep 1: #98407 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumaraditya303 @bedevere-bot @db3l @miss-islington @vstinner @gvanrossum