Skip to content

gh-96678: Avoid undefined behaviour in test - #96672

Merged
pablogsal merged 5 commits into
python:mainfrom
matthiasgoergens:matthias/avoid-ub-in-test
Sep 13, 2022
Merged

gh-96678: Avoid undefined behaviour in test#96672
pablogsal merged 5 commits into
python:mainfrom
matthiasgoergens:matthias/avoid-ub-in-test

Conversation

@matthiasgoergens

@matthiasgoergens matthiasgoergens commented Sep 8, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Signed integer overflow is undefined behaviour.

@matthiasgoergens
matthiasgoergens force-pushed the matthias/avoid-ub-in-test branch from 3529ae1 to 551f8f2 Compare September 8, 2022 05:50
@matthiasgoergens matthiasgoergens mentioned this pull request Sep 8, 2022
Closed
@matthiasgoergens matthiasgoergens changed the title no-issue: Avoid undefined behaviour in test gh-96678: Avoid undefined behaviour in test Sep 8, 2022
@matthiasgoergens

matthiasgoergens commented Sep 13, 2022

Copy link
Copy Markdown
Contributor Author

@pablogsal Would you like to have a look, please? Thanks!

@pablogsal
pablogsal merged commit 6ba686d into python:main Sep 13, 2022
@miss-islington

miss-islington commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @matthiasgoergens for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Sorry @matthiasgoergens and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6ba686d97fd6d2a2169696c6629f7de9482f52db 3.11

@miss-islington

miss-islington commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Sorry, @matthiasgoergens and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6ba686d97fd6d2a2169696c6629f7de9482f52db 3.10

@pablogsal

pablogsal commented Sep 13, 2022

Copy link
Copy Markdown
Member

Could you do the backports using cherry_picker @matthiasgoergens ?

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Sep 13, 2022
@miss-islington

miss-islington commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @matthiasgoergens for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Sorry @matthiasgoergens and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6ba686d97fd6d2a2169696c6629f7de9482f52db 3.11

@matthiasgoergens

matthiasgoergens commented Sep 13, 2022

Copy link
Copy Markdown
Contributor Author

Ok. I'll use cherry_picker later. I'm not on my PC right now.

@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Sep 13, 2022
@miss-islington

miss-islington commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @matthiasgoergens for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2022
@matthiasgoergens @miss-islington
pythongh-96678: Avoid undefined behaviour in test (pythonGH-96672)
b570747 
(cherry picked from commit 6ba686d)

Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 13, 2022

Copy link
Copy Markdown

GH-96795 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 13, 2022
pablogsal pushed a commit that referenced this pull request Sep 13, 2022
@miss-islington @matthiasgoergens
gh-96678: Avoid undefined behaviour in test (GH-96672) (#96795)
cc8b006 
(cherry picked from commit 6ba686d)

Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>

Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>
@matthiasgoergens

matthiasgoergens commented Sep 14, 2022

Copy link
Copy Markdown
Contributor Author

@pablogsal Sorry, I was a bit late. Does this still need the backport?

@matthiasgoergens
matthiasgoergens deleted the matthias/avoid-ub-in-test branch September 14, 2022 09:27
@pablogsal

pablogsal commented Sep 14, 2022

Copy link
Copy Markdown
Member

I think we are still missing the 3.10 backport

@matthiasgoergens

matthiasgoergens commented Sep 14, 2022

Copy link
Copy Markdown
Contributor Author

Oh, I was confused about 3.11 vs 3.10 backport. Yes, I see know that the 3.10 one is still missing.

@matthiasgoergens

matthiasgoergens commented Sep 18, 2022

Copy link
Copy Markdown
Contributor Author

@pablogsal Actually, since we are not going to drop -fwrapv for anything below 3.12, we don't need to backport this fix.

@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@matthiasgoergens @miss-islington @pablogsal @bedevere-bot @ZeroIntensity @kumaraditya303 @AlexWaygood