Skip to content

gh-93592: Port regression test to main branch - #96208

Merged
markshannon merged 1 commit into
python:mainfrom
kristjanvalur:issue-93592-b
Aug 26, 2022
Merged

markshannon merged 1 commit into
python:mainfrom
kristjanvalur:issue-93592-b

Conversation

@kristjanvalur

@kristjanvalur kristjanvalur commented Aug 23, 2022 •

Copy link
Copy Markdown
Contributor

PR #95207 added fixes for 3.10 and earlier.
main doesn't suffer from this issue due to code rewrite, but the regression test should still be added.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 23, 2022
@kristjanvalur
kristjanvalur marked this pull request as ready for review August 23, 2022 12:39
@kristjanvalur

Copy link
Copy Markdown
Contributor Author

@markshannon

@kristjanvalur

Copy link
Copy Markdown
Contributor Author

Ah, didn't notice that a review had already been requested. no rush :)

@markshannon

Copy link
Copy Markdown
Member

Thanks

@markshannon
markshannon merged commit 771eff2 into python:main Aug 26, 2022
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @kristjanvalur for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2022
(cherry picked from commit 771eff2)

Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-96313 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 26, 2022
@kristjanvalur
kristjanvalur deleted the issue-93592-b branch August 26, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants