Repository navigation
Conversation
CAD97
changed the title
|
All commit authors signed the Contributor License Agreement. |
zooba
reviewed
Aug 14, 2022
Comment on lines
+878
to
+879
| non-Python interpreters meant to trampoline into Python, as this could select | ||
| a WSL `bash`, causing the script to run under WSL instead of running natively. |
Member
There was a problem hiding this comment.
I worry that this makes it sound like an appealing feature, not an unintentional side-effect.
Can we warn instead about the command line having to accept the same options as the Python command line? That's the more useful information for someone who's trying to do this on purpose.
(There are also non-WSL "bash.exe"s out there, so I really don't want to start people thinking they can make Windows users run on Linux by putting bash in the shebang...)
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
The launcher in question is deprecated, and the updated one has different behaviour, so this isn't necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I additionally provide a footnote calling out the most likely failure mode.