Skip to content

gh-91217: deprecate msilib #91515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 3 commits into from
Apr 14, 2022
Merged

gh-91217: deprecate msilib #91515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5255da2
Deprecate msilib
brettcannon Apr 13, 2022
2152ec6
Merge branch 'main' into deprecate-msilib
brettcannon Apr 14, 2022
1f9fa98
Add a What's New entry
brettcannon Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Doc/whatsnew/3.11.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,7 @@ Deprecated
* :mod:`chunk`
* :mod:`crypt`
* :mod:`imghdr`
* :mod:`msilib`

(Contributed by Brett Cannon in :issue:`47061`.)

Expand Down
3 changes: 3 additions & 0 deletions Lib/msilib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
import re
import string
import sys
import warnings

warnings._deprecated(__name__, remove=(3, 13))

AMD64 = "AMD64" in sys.version
# Keep msilib.Win64 around to preserve backwards compatibility.
Expand Down
5 changes: 4 additions & 1 deletion Lib/test/test_msilib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
import unittest
from test.support.import_helper import import_module
from test.support.os_helper import TESTFN, unlink
msilib = import_module('msilib')
import warnings
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
msilib = import_module('msilib')
import msilib.schema


Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-04-12-19-42-20.gh-issue-91217.b9_Rz9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deprecate msilib.