Repository navigation
bpo-45171: Remove tests of deprecated logger.warn(). (GH-32139) - #32139
Merged
Merged
Conversation
joukewitteveen
force-pushed
the
logging-no-deprecated-test
branch
from
March 27, 2022 17:22
2577c87 to
16513d8
Compare
vsajip
approved these changes
Mar 27, 2022
vsajip
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #28287. @tirkarthi observed that a deprecation message was emitted by the tests. Rather than catch and ignore this deprecation warning, we might as well forego testing deprecated methods.
In addition, I reworded a comment ever so slightly, as discussed briefly with @vsajip in #28287.
https://bugs.python.org/issue45171