Skip to content

bugfix fix_unicode may delete STRING's parent node #27848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maluyazi wants to merge 1 commit into from
Closed

bugfix fix_unicode may delete STRING's parent node #27848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/lib2to3/fixes/fix_unicode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def transform(self, node, results):
if val[0] in 'uU':
val = val[1:]
if val == node.value:
return node
return None
new = node.clone()
new.value = val
return new
9 changes: 5 additions & 4 deletions Lib/lib2to3/pytree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@ def replace(self, new):
else:
l_children.append(ch)
assert found, (self.children, self, new)
self.parent.changed()
self.parent.children = l_children
parent = self.parent
self.parent = None
parent.children = l_children
for x in new:
x.parent = self.parent
self.parent = None
x.parent = parent
parent.changed()

def get_lineno(self):
"""Return the line number which generated the invocant node."""
Expand Down