Skip to content

bpo-37179: Support asyncio loop.start_tls() for TLS in TLS - #26454

Closed
jborean93 wants to merge 2 commits into
python:mainfrom
jborean93:asyncio-ssl-proxy
Closed

jborean93 wants to merge 2 commits into
python:mainfrom
jborean93:asyncio-ssl-proxy

Conversation

@jborean93

@jborean93 jborean93 commented May 30, 2021 •

Copy link
Copy Markdown
Contributor

Adds the _start_tls_compatible attribute that start_tls checks. This is required to support using a HTTPS proxy when targeting a HTTPS endpoint.

This is my first PR to CPython so I'm unsure what the full process is, let me know if there is anything I'm missing.

https://bugs.python.org/issue37179

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@jborean93

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@CrazyBoyFeng

Copy link
Copy Markdown
Contributor

In addition to signing the CLA, you also need to make a NEWS to introduce this change. Use blurb_it bot to easily make it.

More detailed instructions are on devguide.

@jborean93

Copy link
Copy Markdown
Contributor Author

Thanks @CrazyBoyFeng, I've signed the CLA so hopefully that comes through within a few days and have added the blurb_it entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants