Repository navigation
Conversation
SyslogHandler, emit function add the nul_character to the message. This PR allows the user to choose what character to use to separate messages. The functionality of `append_nul` that was a boolean variable stays the same since the user can override this value since it's a class attribute: From the docs: ``` To enable easier handling of Syslog messages in the face of all these differing daemon behaviours, the appending of the NUL byte has been made configurable, through the use of a class-level attribute, append_nul. This defaults to True (preserving the existing behaviour) but can be set to False on a SysLogHandler instance in order for that instance to not append the NUL terminator. ``` So now this functionality is possible through setting: ``` message_separator_character = '' # using the empty string # instead of doing: # append_nul = False ```
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Better concatenating of the message_separator_character to the msg.
|
This PR is stale because it has been open for 30 days with no activity. |
|
please create an issue on bpo and explain what problem you are trying to solve here. |
iritkatriel
left a comment
iritkatriel
left a comment
There was a problem hiding this comment.
This PR needs an issue on bpo, unit tests and documentation change.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing |
|
Closing this stale PR because the CLA is still not signed. |
4 participants
SyslogHandler, emit function add the nul_character to the message. This PR allows the user to choose what character to use to separate messages.
The functionality of
append_nulthat was a boolean variable stays the same since the user can override this value since it's a class attribute:From the docs:
So now this functionality is possible through setting: