Repository navigation
gh-73180: Chain exceptions rather than dropping the old exception. - #2072
serhiy-storchaka wants to merge 4 commits into
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @loewis and @benjaminp to be potential reviewers. |
162f054 to
8c5cb16
Compare
|
Can you please rebase your change @serhiy-storchaka ? |
|
For |
8c5cb16 to
d69a996
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
left a comment
There was a problem hiding this comment.
Ran test suite and got:
401 tests OK.
Looks good.
|
This PR is stale because it has been open for 30 days with no activity. |
|
The feature seems to be implemented so the PR probably should be closed. try:
raise Exception('first exception')
except:
raise Exception('second exception') |
The PR title is misleading. The PR is to keep the previously overridden exception in a bunch of C functions: _ctypes_extend_error(), call_exc_trace(), call_trace_protected(). |
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR is attached to gh-73180, which is already completed: the fix for that issue landed through other changes, and this PR's approach was not taken or has since become obsolete. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer. |
Uh oh!
There was an error while loading. Please reload this page.