[zanieb]

Older musl headers expose getdents64 as an alias for getdents, whose buffer parameter is struct dirent *. Passing the raw character buffer triggers an incompatible-pointer diagnostic. Pass it through void * to support both that interface and the glibc declaration.

Ports PBS's patch-posixsubprocess-musl-getdents64.patch.

Closes #160359.

• Issue: _posixsubprocess passes an incompatible buffer to older musl getdents64 #160359

[itamaro]

lgtm

[gpshead]

easy for this to regress without the comment or a CI check that fails otherwise. but this code doesn't really change.

[zanieb]

I'll add a comment, seems reasonable

[zanieb]

Feedback on the comment welcome, as I'm not a C developer :)

[itamaro]

Feedback on the comment welcome, as I'm not a C developer :)

comment looks good to me. there was a CI failure (windows free threading). I retried it, I don't see how this change could impact windows, probably a flake.

[miss-islington-app]

Thanks @zanieb for the PR, and @itamaro for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington-app]

Sorry, @zanieb and @itamaro, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 74c91a6fbfa3625cdc850acc99b509cc3d8c6ed0 3.15

[miss-islington-app]

Sorry, @zanieb and @itamaro, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 74c91a6fbfa3625cdc850acc99b509cc3d8c6ed0 3.14

[zanieb]

This does not need backporting to 3.14 or 3.15: both branches call syscall(SYS_getdents64, ...) and do not use the libc getdents64() function affected by this change. The getdents64() call was introduced on main for Python 3.16 by #155518.