Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing bytes before a ZIP archive's central directory can leave a member with a negative local file header offset. Reading that member currently raises
OSErrorfor a real file orValueErrorforBytesIO, soZipFile.testzip()propagates the seek error instead of reporting the corrupt member.Check the offset in
ZipFile.open()before creating the shared file reader and raiseBadZipFile. This letstestzip()return the affected member's name while allowing intact members to be read. Genuine I/O errors continue to propagate.The regression tests cover filenames, temporary files, and
BytesIO, both member names andZipInfoarguments, and reading an intact member from the same damaged archive. A separate test checks that seek failures on a valid archive are not swallowed.Validation on a locally built Windows x64 debug CPython 3.16.0a0:
python_d.exe -m test -v test_zipfile: 603 tests run, 5 skipped, success.git diff --checkpass.Linux and macOS validation has not been run locally.
Fixes #91087.