Conversation
methane
force-pushed
the
codex/json-encode-fastpath
branch
from
September 27, 2026 03:56
4d781e8 to
e425c49
Compare
Contributor
|
There is a behaviour change when users override the Reproducer: import io
import json
class Foo:
pass
_orig_default = json.JSONEncoder.default
def _patched_default(self, o):
if isinstance(o, Foo):
return "FOO"
return _orig_default(self, o)
json.JSONEncoder.default = _patched_default
obj = {"a": Foo()}
print("dumps(obj) ->", json.dumps(obj))
sio = io.StringIO()
json.dump(obj, sio, indent=2)
print("dump(obj, indent=2) ->", sio.getvalue().replace("\n", ""))
try:
print("dumps(obj, indent=2)->", json.dumps(obj, indent=2).replace("\n", ""))
except TypeError as e:
print("dumps(obj, indent=2)-> TypeError:", e)main: this PR: |
hugovk
reviewed
Sep 28, 2026
| return 'custom' | ||
|
|
||
| sio = StringIO() | ||
| self.json.dump({'é': object(), 'a': [1, 2]}, sio, |
Member
There was a problem hiding this comment.
This tests dump() but only dumps() is now changed.
Member
Author
|
I was not expecting monkey patching JSONEncoder to be used in practice rather than creating a subclass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json.dump()with non-default options. #158270