Repository navigation
Conversation
… GIL drop request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a daemon thread in
take_gil()sees that it must exit, it releasedgil->mutexbefore clearing the drop request it had set on the GIL holder. In that gap the holder could rundrop_gil(), still see the bit set, and wait onswitch_condforever, since the only waiter was about to hang. Clearing the bit before releasing the mutex closes the window: the holder needsgil->mutexto drop the GIL, so it now always sees the bit already cleared.I checked it with the lldb recipe from the issue on a
--with-pydebugbuild. Before the change the process hangs with the main thread indrop_gil(). After it, stopping the daemon thread right after the unlock no longer hangs, and the process exits normally.