Repository navigation
gh-144812: Make argparse group classes public - #158045
Merged
savannahostrowski merged 4 commits intoOct 21, 2026
Merged
Conversation
Code that annotates the return values of add_argument_group() and add_mutually_exclusive_group() has to import the private _ArgumentGroup and _MutuallyExclusiveGroup today. Public names give that code a supported type, and the old names stay as aliases so existing imports keep working.
gaborbernat
requested review from
AA-Turner and
savannahostrowski
as code owners
September 23, 2026 23:35
Documentation build overview
125 files changed ·
|
Contributor
Author
|
@savannahostrowski would you be able to take a look here? Thank you. ❤️ |
Member
|
@gaborbernat Sorry for the delay, I'm hoping to take a look at this in the coming week! Thanks for the ping! |
savannahostrowski
left a comment
savannahostrowski
left a comment
Member
There was a problem hiding this comment.
Just a small question about documentation clarity.
We’ll also need a corresponding typeshed update. Their policy is to accept changes for new Python versions after the first beta, so that can follow once 3.16.0b1 is out (we don't need to hold up this PR for it though, just wanted to mention it)
savannahostrowski
approved these changes
Oct 20, 2026
savannahostrowski
enabled auto-merge (squash)
October 20, 2026 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following @savannahostrowski's suggestion on the issue, this makes
ArgumentGroupandMutuallyExclusiveGrouppublic and keeps_ArgumentGroupand_MutuallyExclusiveGroupas aliases, since existing code imports them.The docs cover what they already promised: the objects that
add_argument_group()andadd_mutually_exclusive_group()return, and theiradd_argument()andadd_mutually_exclusive_group()methods. The constructors stay implementation details.This replaces the protocol approach from #150597.