Repository navigation
[3.13] gh-151471: Colorize the soft keyword type in IDLE (GH-151700) - #157993
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeis now colored as a keyword when it starts a statement and is followed by a name, as intype Point = tuple[float, float]. It stays a builtin elsewhere, for example intype = type(1),type(x)ortype in (int, str).(cherry picked from commit 68ed7a5)
Manual backport:
test_recolorize_mainasserts tags at absolute line numbers, and the colorizer colorizes in chunks whose size doubles, so which chunk a line falls into depends on how many lines precede it. This branch has one line fewer in the test source, and the newtypeline ends up in a chunk which starts inside the unterminated string above it. Instead of the two lines there, this addstest_type_soft_keyword, which checks the tag ranges of separate snippets.Co-authored-by: Shixian Li znsoooo@gmail.com
typeas a soft keyword when it begins a statememt #151471