Repository navigation
gh-157840: Special-case member descriptors when using hasattr - #157866
Merged
ZeroIntensity merged 5 commits intoSep 20, 2026
Merged
ZeroIntensity merged 5 commits into
ZeroIntensity merged 5 commits into
Conversation
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Does it affect three-argument getattr()?
Comment on lines
+1927
to
+1931
| // gh-157840: When using hasattr(), slot members without assigned values | ||
| // need to go through __get__(), which involves creating an AttributeError | ||
| // object (which is really slow). There's no way to supply "suppress" | ||
| // to the tp_descr_get() function, so we just special-case member | ||
| // descriptors here to improve performance. |
Member
There was a problem hiding this comment.
Could you please simplify the comment, leaving the substantial part?
Member
Author
Yeah -- performance there is also improved by this PR. |
serhiy-storchaka
approved these changes
Sep 20, 2026
| if (suppress && Py_IS_TYPE(descr, &PyMemberDescr_Type)) { | ||
| PyMemberDef *member = ((PyMemberDescrObject *)descr)->d_member; | ||
| if (member->type == Py_T_OBJECT_EX | ||
| && !(member->flags & Py_AUDIT_READ) && |
Member
There was a problem hiding this comment.
Inconsistent formatting. && after and before line split.
| @@ -0,0 +1,2 @@ | |||
| Speed up calls to :func:`hasattr` for unassigned attributes in an object's | |||
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR:
After: