Repository navigation
gh-156491: Avoid KeyErrors in os._Environ.get() and __contains__() - #156492
Merged
Merged
Conversation
Implement get() and __contains__() on os._Environ directly, which cuts out the cost of raising and catching a KeyError when the keys do not exist.
picnixz
reviewed
Aug 30, 2026
Contributor
Author
|
@StanFromIreland @picnixz I don't have the capability to mark this PR as "skip news", but IMO this isn't worth adding a NEWS entry for. Anything else needed for this PR before it can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
get()and__contains__()onos._Environdirectly, which cuts out the cost of raising and catching aKeyErrorwhen the keys do not exist.