Skip to content

[3.14] gh-152068: Reset PyREPL Colors on prompt finish (#152108) - #154402

Merged
pablogsal merged 3 commits into
python:3.14from
edvilme:backport-gh-152068-pyrepl-color-bug
Sep 24, 2026
Merged

pablogsal merged 3 commits into
python:3.14from
edvilme:backport-gh-152068-pyrepl-color-bug

Conversation

@edvilme

@edvilme edvilme commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

* Use ANSI Escape Codes from Colorize

* Print ANSI Color reset on finish and restore

* 📜🤖 Added by blurb_it.

* Update imports

* Update Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.ThsmJU.rst

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

* Remove news entry

* 📜🤖 Added by blurb_it.

* pythongh-152068: Test ANSI reset is emitted on console finish() and restore()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme
edvilme force-pushed the backport-gh-152068-pyrepl-color-bug branch from 8f11ee1 to 6264ad9 Compare July 21, 2026 23:48
Comment thread Lib/_pyrepl/windows_console.py Outdated
Comment thread Lib/test/test_pyrepl/test_unix_console.py Outdated
Comment thread Lib/test/test_pyrepl/test_windows_console.py
@edvilme

edvilme commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @ambv
I am guessing some of this are remains of the merge conflicts. Fixed and tested locally now :)

@edvilme
edvilme requested a review from ambv July 27, 2026 19:06
@brettcannon
brettcannon self-requested a review August 6, 2026 21:47

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the manual backport!

@pablogsal
pablogsal merged commit bc7cc24 into python:3.14 Sep 24, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants