Repository navigation
gh-152075: Avoid lock contention in _Py_Specialize_LoadGlobal under free threading (gh-153720) - #153720
Merged
Conversation
hawkinsp
force-pushed
the
contention
branch
2 times, most recently
from
July 14, 2026 21:13
9489afc to
6e6e06b
Compare
Member
|
CC @colesbury @mpage |
Contributor
Author
|
@mpage or @colesbury ? |
colesbury
reviewed
Jul 28, 2026
…nder free threading Under high thread concurrency in free-threaded builds, `_Py_Specialize_LoadGlobal` suffers from lock contention when acquiring the critical section mutexes for the `globals` and `builtins` dictionaries during bytecode specialization. This PR skips LOAD_GLOBAL bytecode specialization if acquiring the two object mutexes would block.
colesbury
approved these changes
Jul 31, 2026
Contributor
|
Thanks! |
colesbury
changed the title
colesbury
enabled auto-merge (squash)
July 31, 2026 01:28
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…nder free threading (pythongh-153720) Under high thread concurrency in free-threaded builds, `_Py_Specialize_LoadGlobal` suffers from lock contention when acquiring the critical section mutexes for the `globals` and `builtins` dictionaries during bytecode specialization. This PR skips LOAD_GLOBAL bytecode specialization if acquiring the two object mutexes would block.
kumaraditya303
added
needs backport to 3.14
|
Thanks @hawkinsp for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @hawkinsp for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-158904 is a backport of this pull request to the 3.14 branch. |
|
GH-158905 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
kumaraditya303
pushed a commit
that referenced
this pull request
Oct 6, 2026
…under free threading (gh-153720) (#158904) gh-152075: Avoid lock contention in _Py_Specialize_LoadGlobal under free threading (gh-153720) Under high thread concurrency in free-threaded builds, `_Py_Specialize_LoadGlobal` suffers from lock contention when acquiring the critical section mutexes for the `globals` and `builtins` dictionaries during bytecode specialization. This PR skips LOAD_GLOBAL bytecode specialization if acquiring the two object mutexes would block. (cherry picked from commit ac8ba0c) Co-authored-by: Peter Hawkins <phawkins@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under high thread concurrency in free-threaded builds,
_Py_Specialize_LoadGlobalsuffers from lock contention when acquiring the critical section mutexes for theglobalsandbuiltinsdictionaries during bytecode specialization.This PR skips LOAD_GLOBAL bytecode specialization if acquiring the two object mutexes would block.