Repository navigation
Conversation
- Add execute_json method to Cursor class - Update documentation and add new test file - Implement JSON result generation in C extension
MengAiDev
requested review from
berkerpeksag and
erlend-aasland
as code owners
August 20, 2025 10:06
Member
|
Sorry, but I'm going to close this one until the feature has been sufficiently discussed. In the feature, please don't open PRs when the feature hasn't been accepted and triaged. TiA. |
ssmycelium
reviewed
Aug 20, 2025
| } | ||
|
|
||
| // Complete the JSON query | ||
| PyObject *full_query = PyUnicode_FromFormat("SELECT json_group_array(json_object(%S)) FROM (%U) AS row", column_str, sql); |
There was a problem hiding this comment.
This is quite the pull request! Unfortunately, I have tested this and I've been unable to get back anything other than empty JSON dictionaries.
|
This is pretty impressive! I am curious, did you write this or was it AI assisted? It was a lot of code pretty fast, and it looks very clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--137980.org.readthedocs.build/