Repository navigation
Conversation
Original Author: ammaraskar <ammar@ammaraskar.com> Signed-off-by: ukarroum <ukarroum17@gmail.com>
bedevere-app
Bot
added
awaiting review
docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm re-opening the PR from here: #3072 (original author is @ammaraskar )
Content seems to still be up to date, only change I made (in the 2nd commit) was to remove ">= Vista" for SO_BROADCAST, as it seems supported on all windows versions here: https://learn.microsoft.com/en-us/windows/win32/winsock/sol-socket-socket-options?redirectedfrom=MSDN ?
Spelling issues in original PR seems to be fixed by the original author.
Happy to address any new comments/suggestions.
📚 Documentation preview 📚: https://cpython-previews--132752.org.readthedocs.build/