Repository navigation
gh-124269: Simplify typing.Annotated docs - #130770
Merged
Merged
Conversation
StanFromIreland
requested review from
AlexWaygood and
JelleZijlstra
as code owners
March 2, 2025 19:49
bedevere-app
Bot
added
docs
StanFromIreland
commented
Mar 2, 2025
picnixz
self-requested a review
March 3, 2025 23:03
Member
|
I forgot about this one. If Jelle approves the PR today, go ahead and merge it, or I'll review it tomorrow. |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
approved these changes
Mar 3, 2025
JelleZijlstra
added
needs backport to 3.12
Member
Author
@picnixz friendly ping :-) |
Member
|
I'm currently travelling so I don't have time to review sorry. Nikita/Alex could also review the PR but I trust Jelle's judgment on this one so if he wants to merge it, go ahead. I can review it when I'm at the airport in a few hours though |
picnixz
reviewed
Mar 7, 2025
picnixz
reviewed
Mar 8, 2025
picnixz
reviewed
Mar 13, 2025
picnixz
left a comment
picnixz
left a comment
Member
There was a problem hiding this comment.
I'm unusure whether the import are actually needed because the current code has from typing import Annotated, get_origin and then a different doctest block for get_origin(Password) so I don't know if they're correctly being tested. Apparently, yes though.
picnixz
approved these changes
Mar 13, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Thanks @StanFromIreland for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 14, 2025
--------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131222 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 14, 2025
--------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131223 is a backport of this pull request to the 3.12 branch. |
picnixz
added a commit
that referenced
this pull request
Mar 14, 2025
gh-124269: Simplify `typing.Annotated` docs (GH-130770) --------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
added a commit
that referenced
this pull request
Mar 14, 2025
gh-124269: Simplify `typing.Annotated` docs (GH-130770) --------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
mikec9
pushed a commit
to mikec9/cpython
that referenced
this pull request
Mar 14, 2025
…0770) (python#131223) pythongh-124269: Simplify `typing.Annotated` docs (pythonGH-130770) --------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
--------- Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped relevant bullet points into paragraphs. Maybe I took too many creative liberties...
Request: @JelleZijlstra @sobolevn @picnixz
typing.Annotateddocs #124269