Repository navigation
gh-124120: Document Annotated.__origin__ - #124125
Merged
Merged
Conversation
sobolevn
added
needs backport to 3.12
sobolevn
requested review from
AlexWaygood and
JelleZijlstra
as code owners
September 16, 2024 13:37
sobolevn
changed the title
get_origin to access Annotated originAnnotated.__origin__
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
AlexWaygood
reviewed
Sep 16, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
This change is fine but I don't like this long bulleted list of individual issues. We should rewrite it to a more organized form.
Member
Author
Ok, I will open an new issue for that!
So, I will merge it later today if no one else has any feedback. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit faef3fa) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-124416 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit faef3fa) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-124417 is a backport of this pull request to the 3.12 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotated.__origin__#124120📚 Documentation preview 📚: https://cpython-previews--124125.org.readthedocs.build/