Skip to content

bpo-34160: Add the sort attribute to the xml.dom.minidom.Node.writexml method - #12354

Closed
matrixise wants to merge 3 commits into
python:masterfrom
matrixise:bpo-34160
Closed

matrixise wants to merge 3 commits into
python:masterfrom
matrixise:bpo-34160

Conversation

@matrixise

@matrixise matrixise commented Mar 15, 2019 •

Copy link
Copy Markdown
Member

…texml and xml.dom.minidom.Node.writexml method.

Document the new sort attribute and xml.dom.minidom.Document.writexml
method.
@matrixise
matrixise marked this pull request as ready for review March 15, 2019 20:36
@matrixise matrixise closed this Mar 15, 2019
@matrixise matrixise reopened this Mar 15, 2019
@matrixise

Copy link
Copy Markdown
Member Author

I closed/reopen the PR there was an issue with appveyor

@matrixise

Copy link
Copy Markdown
Member Author

in fact, there was some issues in my code :/ not detected locally but fortunately AppVeyor was there ;-)

@tirkarthi

Copy link
Copy Markdown
Member

I think this is the same as #10452 that has a discussion about adding a new sort parameter.

@matrixise

Copy link
Copy Markdown
Member Author

I close this PR

@matrixise matrixise closed this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants