Repository navigation
gh-121583: Remove dependency from pystats.h to internal header file - #121587
Merged
Merged
Conversation
mdboom
added
needs backport to 3.13
ZeroIntensity
requested changes
Jul 10, 2024
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity
approved these changes
Jul 10, 2024
brandtbucher
approved these changes
Jul 16, 2024
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Thanks @mdboom! I'm going to go ahead and land this.
|
Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
…file (pythonGH-121587) (cherry picked from commit f036a46) Co-authored-by: Michael Droettboom <mdboom@gmail.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-121880 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just uses a fixed number of slots for recording uops stats that is enforced to be big enough.
Alternatively, we could generate the correct number and put it in a public header, but that seems like overkill.