Repository navigation

gh-113993: Allow interned strings to be mortal, and fix related issues - #120520

Merged

encukou merged 79 commits into

python:mainfrom

encukou:immortal-interned

Jun 21, 2024

Commits on Jun 14, 2024
- Declare explicit interning routines
  encukou
  committed
  2b74021
- Use _PyUnicode_InternStatic for the statically allocated stuff
  encukou
  committed
  0aedb83
- Add _PyUnicode_InternStatic and extra checks
  encukou
  committed
  aad79b2
- Check against immortalizing un-interned strings
  encukou
  committed
  5413223
- Add _PyUnicode_InternImmortal & make `marshal` use it
  encukou
  committed
  23845fb
- Remove special case that makes previously-immortal strings STATIC
  encukou
  committed
  9ece220
- Split _PyUnicode_InternMortal and _PyUnicode_InternImmortal
  encukou
  committed
  7c62641
- Do the refcnt dance in _PyUnicode_InternMortal & _PyUnicode_ClearInterned
  encukou
  committed
  62a35a1
- Deallocate mortal interned strings
  encukou
  committed
  ac55a05
- Use _PyUnicode_InternMortal in codecs
  encukou
  committed
  2466ae9
- Start a notes document
  encukou
  committed
  032ac17
- Handle attempts to "overwrite" interned heap types by static ones
  encukou
  committed
  198d9c6
- Intern statically allocated non-identifier strings at init
  encukou
  committed
  86ccb08
- Parenthesize the LATIN1 macro argument
  encukou
  committed
  e34b8da
- Don't create the per-interp interned_dict until after InitStaticStrings
  encukou
  committed
  66338fe
- Move hashmap destroy to _PyUnicode_ClearInterned (symmetry with creation)
  encukou
  committed
  9f16cb0
- Special-case short string singletons
  encukou
  committed
  e27abfc
- Verify we don't add process-global entries after a per-interp dict exists
  encukou
  committed
  89f24df
- More editing of the InternalDocs write-up
  encukou
  committed
  b965acf
- Only readjust refleak tests for *immortal* interned strings
  encukou
  committed
  4b69712
- Be pedantic with the ref total
  encukou
  committed
  b2c9865
- Split InternInPlace in sysmodule
  encukou
  committed
  cf7cb72
- Split InternInPlace in import
  encukou
  committed
  85f9fe0
- Split InternInPlace in getargs
  encukou
  committed
  a288389
- Use mortal strings in type_setattro
  encukou
  committed
  6036cb1
- Use mortal string in type_module
  encukou
  committed
  01f2dbf
- Use mortal strings for object attributes
  encukou
  committed
  73f7fb3
- Use mortal strings for code object names
  encukou
  committed
  13be4e7
- Use mortal strings for code constants
  encukou
  committed
  1930919
- Use mortals in pickle
  encukou
  committed
  d45f20b
- Use mortals for PyDict_SetItemString keys
  encukou
  committed
  348d95c
- Use mortals in operator: methodcaller_new
  encukou
  committed
  04f080e
- Use mortals in operator: attrgetter_new
  encukou
  committed
  afe5400
- Simplify logic in _PyUnicode_InternImmortal
  encukou
  committed
  fe0b8c5
- Immortalize ill interned strings in the free-threaded build
  encukou
  committed
  1116191
- Rewrite the write-up
  encukou
  committed
  f10e521
- Restore immortalization for PyDict_SetItemString.
  encukou
  committed
  0787f8f
- Intern single-byte (latin1) strings at startup in free-threaded build
  encukou
  committed
  0d56eba
- Make the three sets of singletons disjoint
  encukou
  committed
  8b32762
- One more single-char string in _Py_STR
  encukou
  committed
  24bf76a
- Use a less unwieldy name
  encukou
  committed
  2fb04fd
- Adjust comments & writeup
  encukou
  committed
  26fa26e
- Don't call _Py_SetImmortal on strings.
  encukou
  committed
  9b14dbb
- Beef up the tests
  encukou
  committed
  ac6dfae
- Fix comment
  encukou
  committed
  a9e91b1
- A bit more thought-through error handling for failed PyDict_Pop
  encukou
  committed
  ee0f068
- Switch parser to PyUnicode_InternImmortal
  encukou
  committed
  61bf404
- Touch up comments
  encukou
  committed
  80ce95b
- Switch public PyUnicode API to _PyUnicode_InternImmortal
  encukou
  committed
  70aa294
- Add an assert to _PyUnicode_EqualToASCIIId
  encukou
  committed
  de2ff7f
- Remove #ifdef Py_DEBUG from the body of _PyUnicode_ClearInterned.
  encukou
  committed
  0e6744e
- Consolidate the interning logic
  encukou
  committed
  c50e151
- Fix the free-threading initialization
  encukou
  committed
  08798d0
- Typo in comments
  encukou
  committed
  62959cd
- Add blurb
  encukou
  committed
  f62ccc6
- Guard call to debug function
  encukou
  committed
  86cf124
- Avoid -bb warnings in tests
  encukou
  committed
  f2e857e
- Add typing to a clinic function
  encukou
  committed
  6011c05
- Work around build failure on macOS clang
  encukou
  committed
  7e8d727
Commits on Jun 17, 2024
- Silence a mypy error
  encukou
  committed
  ccb7f42
- _PyCodec_Lookup: Immortalize key on success
  encukou
  committed
  e0bb1c2
- getargs.c: Immortalize the kwtuple keys
  encukou
  committed
  975e4ba
- Don't re-mortalize interned immortals at interpreter shutdown (in non-debug)
  encukou
  committed
  1c05a60
- Avoid `case` label on a declaration (invalid in standard C and, fortunately, GHA clang)
  encukou
  committed
  5ac3c5f
Commits on Jun 18, 2024
- Merge in the main branch
  encukou
  committed
  686d2b6
Commits on Jun 19, 2024
- Remove PyUnicode_InternImmortal from the header
  encukou
  committed
  7d79d10
- Move _Py_LATIN1_CHR to pycore_global_strings.h
  encukou
  committed
  d4eb879
- Remove mistaken check in _pickle.c
  encukou
  committed
  f7df09a
- Comment/doc clarifications, rewordings; PEP-7 style
  encukou
  committed
  fe7fb13
- Add a pedantic DECREF
  encukou
  committed
  7a75099
- Use more straightforward signatures for the internal functions
  encukou
  committed
  ac402d8
- Group _PyUnicode_Intern funcs in the header
  encukou
  committed
  aa58c01
- Break out init_global_interned_strings & clear_global_interned_strings
  encukou
  committed
  929d0bc
- Merge in the main branch
  encukou
  committed
  44c0192
Commits on Jun 20, 2024
- Fix function declaration
  encukou
  committed
  9e3ce44
- Fix return value
  encukou
  committed
  2ebf8a0
- Convert check to assert
  encukou
  committed
  bf49f61
- Limit _PyUnicode_InternStatic to runtime initialization
  encukou
  committed
  6d668e6
- Add a comment for _Py_hashtable_new_full destroys
  encukou
  committed
  fd8ca83

Commits

Commits on Jun 14, 2024

Commits on Jun 17, 2024

Commits on Jun 18, 2024

Commits on Jun 19, 2024

Commits on Jun 20, 2024