Repository navigation
gh-109961: Use proper module for copy method docs - #110027
Merged
Merged
Conversation
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Other anchors for object methods do not contain "builtins." prefix. For example https://docs.python.org/3/reference/datamodel.html#object.__format__.
Did you try to use .. currentmodule:: .? I am not sure whether :module: . works.
Member
Author
|
@serhiy-storchaka hm, indeed. Will try that as well! |
Member
Author
|
The result is identical. Please, take a look. The difference with |
AA-Turner
reviewed
Sep 28, 2023
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Member
Author
Member
|
@sobolevn -- when you do the backports, please could you include this commit in them? Saves merge conflicts etc. A |
serhiy-storchaka
approved these changes
Sep 29, 2023
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…10027) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets correct
:module:context forbuiltins.object.{__copy__,__deepcopy__,__replace__}Now their urls are:
library/copy.html#object.__copy__library/copy.html#object.__deepcopy__library/copy.html#object.__replace__All links seem to work.
CC @AA-Turner @hugovk @serhiy-storchaka
Refs #109968
__replace__method incopydocs: consider addingcopy.SupportsReplace? #109961📚 Documentation preview 📚: https://cpython-previews--110027.org.readthedocs.build/en/110027/library/copy.html