Repository navigation

gh-109094: replace frame->prev_instr by frame->instr_ptr - #109095

Merged

iritkatriel merged 102 commits into

python:mainfrom

iritkatriel:instr_ptr

Oct 26, 2023

Merged

gh-109094: replace frame->prev_instr by frame->instr_ptr#109095
iritkatriel merged 102 commits into
python:mainfrom
iritkatriel:instr_ptr

Commits on Sep 7, 2023
- add instr_ptr and assert it's 1 more than prev_instr in SET_LOCALS_FROM_FRAME
  iritkatriel
  committed
  637b5da
- fix YIELD_VALUE
  iritkatriel
  committed
  ffb980c
- fix test_sys
  iritkatriel
  committed
  82a5b92
- update instr_ptr in _PyOptimizer_BackEdge
  iritkatriel
  committed
  1fc0df1
- All tests pass except test_jump_from_yield (which is disabled)
  iritkatriel
  committed
  6bbb1c2
- assert always
  iritkatriel
  committed
  be6d428
- remove unnecessary stuff
  iritkatriel
  committed
  bbe8e2c
- fix test_sys expected sizes
  iritkatriel
  committed
  50a1f3a
- add assert
  iritkatriel
  committed
  4beb50b
- use instr_ptr instead of prev_instr in genobject.c
  iritkatriel
  committed
  8e4a310
- update executor.c
  iritkatriel
  committed
  58d3bc5
- remove unecessary setting of prev_instr in _Py_call_instrumentation_jump
  iritkatriel
  committed
  909de93
- replace assignment by assertion in _Py_call_instrumentation_line
  iritkatriel
  committed
  0a06b75
- revert change to signature of _PyFrame_PushTrampolineUnchecked
  iritkatriel
  committed
  da6c97b
- prev_instr --> previous_instr to avoid confusion
  iritkatriel
  committed
  6488d69
- revert change to JUMPBY
  iritkatriel
  committed
  6c684b0
Commits on Sep 8, 2023
- use instr_ptr in _PyFrame_OpAlreadyRan
  iritkatriel
  committed
  b6a8b0c
- use instr_ptr in _PyFrame_IsIncomplete
  iritkatriel
  committed
  1ceeba1
- use instr_ptr in LOAD_IP
  iritkatriel
  committed
  371fa66
Commits on Sep 11, 2023
- use intr_ptr in INSTRUMENTED_RESUME
  iritkatriel
  committed
  557f36f
- Python/optimizer.c
  iritkatriel
  committed
  cb22365
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  9875704
Commits on Sep 14, 2023
- tweaks
  iritkatriel
  committed
  aea21a6
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  b2221d1
- skip test_long_loop for now
  iritkatriel
  committed
  7078fe5
Commits on Sep 15, 2023
- added harness for LASTI migration, but no functional change yet
  iritkatriel
  committed
  3ac7cc6
Commits on Sep 17, 2023
- WIP
  iritkatriel
  committed
  5a672a4
Commits on Sep 18, 2023
- WIP
  iritkatriel
  committed
  4fd470e
- WIP
  iritkatriel
  committed
  d676f9c
Commits on Sep 19, 2023
- WIP
  iritkatriel
  committed
  1afba52
- WIP
  iritkatriel
  committed
  8b1643a
Commits on Sep 20, 2023
- fix bug
  iritkatriel
  committed
  a386dee
Commits on Sep 26, 2023
- add dump_frame
  iritkatriel
  committed
  32b2cfd
- add yield_offset
  iritkatriel
  committed
  add2321
- give the POP_TOP after a RETURN_GENERATOR the same line number
  iritkatriel
  committed
  218228b
Commits on Sep 27, 2023
- fix getattr overridden
  iritkatriel
  committed
  0d0c25d
- add more data to debug output
  iritkatriel
  committed
  4418fc4
- disable Uops tests for now
  iritkatriel
  committed
  e07b415
Commits on Sep 28, 2023
- always assert
  iritkatriel
  committed
  cb96aa0
- remove some debug prints
  iritkatriel
  committed
  729944f
- use new lasti macro
  iritkatriel
  committed
  44e37ee
- rename local
  iritkatriel
  committed
  b3b55ee
Commits on Sep 29, 2023
- use prev_traced_instr instead of prev_instr in line tracing
  iritkatriel
  committed
  6f0fe7b
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  2cf7e94
- remove some debug prints
  iritkatriel
  committed
  66005ce
- don't use prev_instr in jump instrumentation
  iritkatriel
  committed
  c9a9601
Commits on Sep 30, 2023
- remove prev_instr and return_offset from frame
  iritkatriel
  committed
  764bd37
- skip failing tests
  iritkatriel
  committed
  30e74de
- fix test_sys_settrace tests
  iritkatriel
  committed
  b63c8da
- re-enable some tests
  iritkatriel
  committed
  8bade18
Commits on Oct 11, 2023
- remove prev_traced_instr
  iritkatriel
  committed
  8b14bde
- unskip tests which are now passing
  iritkatriel
  committed
  d1387ed
- one more test
  iritkatriel
  committed
  9c10b8d
- more tests
  iritkatriel
  committed
  287c1a5
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  3639796
- rename new_return_offset to next_instr_offset
  iritkatriel
  committed
  41bba62
- remove debug prints
  iritkatriel
  committed
  d363fc3
- tidy up
  iritkatriel
  committed
  efa8eab
- use constants
  iritkatriel
  committed
  86cf45f
Commits on Oct 12, 2023
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  19da0c0
Commits on Oct 13, 2023
- add and use constant NEXT_INSTR_OFFSET_FOR_YIELD
  iritkatriel
  committed
  cbee4f8
- remove yield_offset from the frame
  iritkatriel
  committed
  3a9a029
- re-enable test_sys
  iritkatriel
  committed
  a44f4db
- adjust shim frame
  iritkatriel
  committed
  62ca8ce
- tweak assertions
  iritkatriel
  committed
  3fa0423
- tweaks
  iritkatriel
  committed
  488e5e7
- cleanup
  iritkatriel
  committed
  85f08bc
- add news
  iritkatriel
  committed
  012f911
Commits on Oct 17, 2023
- fix most uop tests
  iritkatriel
  committed
  3fcfc47
- _PUSH_FRAME doesn't need to update next_instr_offset
  iritkatriel
  committed
  d796107
Commits on Oct 18, 2023
- Apply suggestions from code review
  
  iritkatriel
  and
  gvanrossum
  authored
  76474e3
- fix ()
  iritkatriel
  committed
  3fcbc3a
- assert YIELD has no caches
  iritkatriel
  committed
  2043c83
- apply review feedback
  iritkatriel
  committed
  3511bef
- remove obsolete comment
  iritkatriel
  committed
  6a85588
Commits on Oct 20, 2023
- remove frame->instr_ptr--; in executor
  iritkatriel
  committed
  8ccbe6e
Commits on Oct 21, 2023
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  d55f048
Commits on Oct 22, 2023
- Add uops support to instr_ptr branch (#55)
  gvanrossum
  authored
  b7f86a7
Commits on Oct 23, 2023
- address some of Mark's comments
  iritkatriel
  committed
  c6d69da
- address some of Mark's comments
  iritkatriel
  committed
  0da356b
Commits on Oct 24, 2023
- apply next_instr_offset on return/yield
  iritkatriel
  committed
  0089b30
- remove debug stuff
  iritkatriel
  committed
  e1ab25d
- prev can't be NULL
  iritkatriel
  committed
  3e0b86d
Commits on Oct 25, 2023
- yield doesn't need to use next_instr_offset
  iritkatriel
  committed
  d0b2469
- apply next_instr_offset to next_instr instead of instr_ptr
  iritkatriel
  committed
  7d15260
- rename next_instr_offset to return_offset
  iritkatriel
  committed
  2986b9c
- Merge remote-tracking branch 'upstream/main' into instr_ptr
  iritkatriel
  committed
  91eb2a4
- disable a few tier2 tests
  iritkatriel
  committed
  1bd0be3
- revert some unnecessary changes
  iritkatriel
  committed
  91dddc0
- fix ENTER_EXECUTOR and re-enable the tests
  iritkatriel
  committed
  f3c25b5
- cleanup
  iritkatriel
  committed
  6617d60
- _SAVE_CURRENT_IP --> _SAVE_RETURN_OFFSET
  iritkatriel
  committed
  661dad0
- assignment to assertion
  iritkatriel
  committed
  5a5103b
- address (most of) Guido's comments
  iritkatriel
  committed
  0b68e54
- LOAD_IP takes the offset
  iritkatriel
  committed
  96a996c
- no need to zero return_offset
  iritkatriel
  committed
  8574469
- remove OPARG_SET_IP
  iritkatriel
  committed
  855513a
Commits on Oct 26, 2023
- fix test_gdb?
  iritkatriel
  committed
  0cf9ec9
- move explanations to frame_layout.md
  iritkatriel
  committed
  82f9d9d
- Mark's comments
  iritkatriel
  committed
  95b63df
- same tweak to INSTRUMENTED_YIELD_VALUE as well
  iritkatriel
  committed
  f2d149b
- Merge branch 'main' into instr_ptr
  iritkatriel
  authored
  578e266

Commits

Commits on Sep 7, 2023

Commits on Sep 8, 2023

Commits on Sep 11, 2023

Commits on Sep 14, 2023

Commits on Sep 15, 2023

Commits on Sep 17, 2023

Commits on Sep 18, 2023

Commits on Sep 19, 2023

Commits on Sep 20, 2023

Commits on Sep 26, 2023

Commits on Sep 27, 2023

Commits on Sep 28, 2023

Commits on Sep 29, 2023

Commits on Sep 30, 2023

Commits on Oct 11, 2023

Commits on Oct 12, 2023

Commits on Oct 13, 2023

Commits on Oct 17, 2023

Commits on Oct 18, 2023

Commits on Oct 20, 2023

Commits on Oct 21, 2023

Commits on Oct 22, 2023

Commits on Oct 23, 2023

Commits on Oct 24, 2023

Commits on Oct 25, 2023

Commits on Oct 26, 2023