Skip to content

Fix bpo-19217: Calling assertEquals for moderately long list takes too long - #10034

Closed
srinivasreddy wants to merge 1 commit into
python:masterfrom
srinivasreddy:19217
Closed

srinivasreddy wants to merge 1 commit into
python:masterfrom
srinivasreddy:19217

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Oct 22, 2018 •

Copy link
Copy Markdown
Contributor

@matrixise

Copy link
Copy Markdown
Member

@srinivasreddy The title of your PR is wrong, why "Closes" ?

@srinivasreddy srinivasreddy changed the title Closes bpo-19217: Calling assertEquals for moderately long list takes too long Fix bpo-19217: Calling assertEquals for moderately long list takes too long Oct 22, 2018

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok for me

@lisroach

lisroach commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

Is this still adding the header mentioned in the issue:


+++
@@ -1 +1 @@

? I do find that to look odd. Could this be improved?

@erlend-aasland

Copy link
Copy Markdown
Contributor

@lisroach Yes, this is still adding the diff header. Could be improved by adding fromfile='expected', tofile='actual' to difflib.unified_diff() in Lib/unittest/case.py and Lib/unittest/test/test_case.py.

Example output:

--- expected
+++ actual
@@ -9997,4 +9997,4 @@
  1,
  1,
  1,
- 1]
+ 2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants