Repository navigation

gh-99955: standardize return values of functions in compiler's code-gen - #100010

Merged

iritkatriel merged 96 commits into

python:mainfrom

iritkatriel:return_values

Dec 12, 2022

Commits on Dec 4, 2022
- compiler_setup returns SUCCESS/ERROR
  iritkatriel
  committed
  97d929f
- cfg_builder_init returns SUCCESS/ERROR
  iritkatriel
  committed
  0e14141
- compiler_set_qualname returns SUCCESS/ERROR
  iritkatriel
  committed
  5d81ad0
- basicblock_addop returns SUCCESS/ERROR
  iritkatriel
  committed
  6d56a1b
- cfg_builder_addop returns SUCCESS/ERROR
  iritkatriel
  committed
  3b87215
- cfg_builder_addop_noarg returns SUCCESS/ERROR
  iritkatriel
  committed
  829ed2d
- cfg_builder_addop_i returns SUCCESS/ERROR
  iritkatriel
  committed
  8be8f0b
- compiler_addop_name returns SUCCESS/ERROR
  iritkatriel
  committed
  9374ac0
- compiler_addop_o and compiler_addop_load_const returns SUCCESS/ERROR
  iritkatriel
  committed
  9d21d49
- cfg_builder_addop_j returns SUCCESS/ERROR
  iritkatriel
  committed
  a67c612
- prepend macros with _
  iritkatriel
  committed
  844b78f
- add new versions of the macros (not used yet)
  iritkatriel
  committed
  4ca4b8c
- compiler_enter_scope returns SUCCESS/ERROR
  iritkatriel
  committed
  9baeb63
- find_add returns bool
  iritkatriel
  committed
  566acc5
- compiler_push_fblock returns SUCCESS/ERROR
  iritkatriel
  committed
  93287a1
- compiler_call_exit_with_nones returns SUCCESS/ERROR
  iritkatriel
  committed
  8515380
- pop_except_and_reraise returns SUCCESS/ERROR
  iritkatriel
  committed
  13583a3
- compiler_add_yield_from returns SUCCESS/ERROR
  iritkatriel
  committed
  1fd574a
- compiler_unwind_fblock returns SUCCESS/ERROR
  iritkatriel
  committed
  a3d5cad
- compiler_unwind_fblock_stack returns SUCCESS/ERROR
  iritkatriel
  committed
  6fe5dd7
- compiler_body returns SUCCESS/ERROR
  iritkatriel
  committed
  297a0d6
- compiler_codegen returns SUCCESS/ERROR
  iritkatriel
  committed
  c504cd3
- compiler_make_closure returns SUCCESS/ERROR
  iritkatriel
  committed
  b6028e2
- compiler_decorators and compiler_apply_decorators return SUCCESS/ERROR
  iritkatriel
  committed
  19235f7
- compiler_visit_kwonlydefaults returns SUCCESS/ERROR
  iritkatriel
  committed
  9d93635
- forbidden_name returns bool
  iritkatriel
  committed
  dfbe826
- compiler_check_debug_one_arg, compiler_check_debug_args, compiler_check_debug_args_seq return SUCCESS/ERROR
  iritkatriel
  committed
  9757b0d
- insert_instruction, wrap_in_stopiteration_handler return SUCCESS/ERROR
  iritkatriel
  committed
  151e8f0
- compiler_class returns SUCCESS/ERROR
  iritkatriel
  committed
  1409c3e
- compiler_return returns SUCCESS/ERROR
  iritkatriel
  committed
  d1a28e4
- compiler_augassign return SUCCESS/ERROR
  iritkatriel
  committed
  15b73da
- compiler_annassign returns SUCCESS/ERROR
  iritkatriel
  committed
  40615da
- compiler_for returns SUCCESS/ERROR
  iritkatriel
  committed
  90bb804
- compiler_while returns SUCCESS/ERROR
  iritkatriel
  committed
  42dca92
- compiler_if returns SUCCESS/ERROR
  iritkatriel
  committed
  fdf615f
- compiler_try_finally returns SUCCESS/ERROR
  iritkatriel
  committed
  99a7257
- compiler_try_except returns SUCCESS/ERROR
  iritkatriel
  committed
  0902cf1
- compiler_try_star_finally, compiler_try_star_except return SUCCESS/ERROR
  iritkatriel
  committed
  2680b56
- compiler_try, compiler_try_star return SUCCESS/ERROR
  iritkatriel
  committed
  6136f33
- compiler_assert returns SUCCESS/ERROR
  iritkatriel
  committed
  73d8b72
- compiler_import, compiler_import_as return SUCCESS/ERROR
  iritkatriel
  committed
  6966b26
- compiler_from_import, compiler_break return SUCCESS/ERROR
  iritkatriel
  committed
  1cdf83b
- compiler_continue, compiler_with, compiler_async_with return SUCCESS/ERROR
  iritkatriel
  committed
  229d6fd
- compiler_stmt_expr, compiler_async_for return SUCCESS/ERROR
  iritkatriel
  committed
  f8b658e
- ensure_fail_pop return SUCCESS/ERROR
  iritkatriel
  committed
  5d8f93b
- jump_to_fail_pop return SUCCESS/ERROR
  iritkatriel
  committed
  71e13c2
- emit_and_reset_fail_pop, compiler_error_duplicate_store return SUCCESS/ERROR
  iritkatriel
  committed
  4f10612
- pattern_helper_rotate return SUCCESS/ERROR
  iritkatriel
  committed
  a5d017d
- pattern_helper_store_name returns SUCCESS/ERROR
  iritkatriel
  committed
  cbb63b0
- pattern_unpack_helper returns SUCCESS/ERROR
  iritkatriel
  committed
  06ba665
- pattern_helper_sequence_unpack returns SUCCESS/ERROR
  iritkatriel
  committed
  0b84a46
- pattern_helper_sequence_subscr, compiler_pattern_subpattern return SUCCESS/ERROR
  iritkatriel
  committed
  c8acddb
- compiler_pattern_as, compiler_pattern_star return SUCCESS/ERROR
  iritkatriel
  committed
  44d5452
- compiler_pattern_class, validate_kwd_attrs return SUCCESS/ERROR
  iritkatriel
  committed
  77d8b27
- compiler_pattern_mapping returns SUCCESS/ERROR
  iritkatriel
  committed
  2e23b8f
- compiler_pattern_or returns SUCCESS/ERROR
  iritkatriel
  committed
  31bc6cd
- compiler_pattern_sequence returns SUCCESS/ERROR
  iritkatriel
  committed
  42c36cf
- compiler_pattern_value, compiler_pattern_singleton returns SUCCESS/ERROR
  iritkatriel
  committed
  a0a19dc
- compiler_pattern return SUCCESS/ERROR
  iritkatriel
  committed
  ac78f3c
- compiler_match, compiler_match_inner return SUCCESS/ERROR
  iritkatriel
  committed
  57bffde
- compiler_function return SUCCESS/ERROR
  iritkatriel
  committed
  855cdde
- compiler_call_helper returns SUCCESS/ERROR
  iritkatriel
  committed
  45028d5
- check_caller, compiler_call RETURN SUCCESS/ERROR
  iritkatriel
  committed
  5843200
- check_compare, compiler_addcompare return SUCCESS/ERROR
  iritkatriel
  committed
  7611a97
- compiler_ifexp, compiler_boolop, unpack_helper, assignment_helper return SUCCESS/ERROR
  iritkatriel
  committed
  3122826
- addop_yield, addop_binary compiler_addcompare return SUCCESS/ERROR
  iritkatriel
  committed
  46e7471
- compiler_with_except_finish return SUCCESS/ERROR
  iritkatriel
  committed
  a31d078
- compiler_lambda return SUCCESS/ERROR
  iritkatriel
  committed
  95a47a6
- compiler_visit_defaults return SUCCESS/ERROR
  iritkatriel
  committed
  56178d3
- compiler_visit_*annotation(s) return SUCCESS/ERROR
  iritkatriel
  committed
  0c6687d
Commits on Dec 5, 2022
- compiler_comprehension_* return SUCCESS/ERROR
  iritkatriel
  committed
  0ee940f
- starunpack_helper return SUCCESS/ERROR
  iritkatriel
  committed
  6a37392
- compiler_list, compiler_tuple, compiler_subdict, compiler_dict return SUCCESS/ERROR
  iritkatriel
  committed
  40cb86c
- are_all_items_const returns bool
  iritkatriel
  committed
  b8cd5a3
- compiler_comprehension/listcomp/dictcomp/setcomp/genexp return SUCCESS/ERROR
  iritkatriel
  committed
  1bc7cc6
- compiler_jump_if returns SUCCESS/ERROR
  iritkatriel
  committed
  93af682
- maybe_optimize_method_call, compiler_call_simple_kw_helper return SUCCESS/ERROR
  iritkatriel
  committed
  13b6f8d
- compiler_joined_str, compiler_formatted_value return SUCCESS/ERROR
  iritkatriel
  committed
  3bfb5d7
- compiler_slice returns SUCCESS/ERROR
  iritkatriel
  committed
  6d40de7
- compiler_nameop returns SUCCESS/ERROR
  iritkatriel
  committed
  49da813
- compiler_subscript and helpers return SUCCES/ERROR
  iritkatriel
  committed
  adea67e
- annotations related functions return SUCCESS/ERROR
  iritkatriel
  committed
  40f7d15
- compiler_subkwargs return SUCCESS/ERROR
  iritkatriel
  committed
  07756b4
- visitor functions return SUCCESS/ERROR
  iritkatriel
  committed
  45d26ef
- compiler_error returns ERROR
  iritkatriel
  committed
  d5b624b
- compiler_warn returns SUCCESS/ERROR
  iritkatriel
  committed
  ef1001c
- use RETURN_IF_ERROR in a few places
  iritkatriel
  committed
  e1a5414
- minor tweaks
  iritkatriel
  committed
  e2b6368
- reduce diff, revert error
  iritkatriel
  committed
  dad4799
- Merge remote-tracking branch 'upstream/main' into return_values
  iritkatriel
  committed
  730f5fd
Commits on Dec 12, 2022
- Merge branch 'main' into return_values
  iritkatriel
  authored
  137a9b0
- 📜🤖 Added by blurb_it.
  blurb-it[bot]
  authored
  9c7d675
- Remove unnecessary ()
  iritkatriel
  authored
  4271c43
- -1 --> ERROR
  
  iritkatriel
  and
  markshannon
  authored
  48802dc
- Merge branch 'main' into return_values
  iritkatriel
  authored
  77db056
- whitespace
  iritkatriel
  authored
  a47b482

Commits

Commits on Dec 4, 2022

Commits on Dec 5, 2022

Commits on Dec 12, 2022