Skip to content

descr_set_trampoline_call return type should be int not PyObject* #99443

Closed

Description

@hoodmane

getset_set return type is int, descr_set_trampoline_call's return type needs to be the same. I think this was a copy-paste error that occurred when applying my patch where descr_set_trampoline_call returns int:
https://github.com/pyodide/pyodide/blob/main/cpython/patches/0001-Patch-in-call-trampolines-to-handle-fpcast-troubles.patch

Linked PRs

Activity

  1. hoodmane commented on Nov 14, 2022

    @hoodmane
    ContributorAuthor

    See also #91318. This comes up from Pyodide's upgrade to Python 3.11. I'm not sure why I didn't notice it before.

    @tiran

  2. added a commit that references this issue on Nov 16, 2022
  3. added 2 commits that reference this issue on Nov 16, 2022
  4. hauntsaninja commented on Nov 29, 2022

    @hauntsaninja
    Contributor

    Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions