Skip to content

ssl.SSLSocket.shared_ciphers always returns server cipher list #96931

Closed
Closed
ssl.SSLSocket.shared_ciphers always returns server cipher list#96931
Labels
topic-SSLtype-bugAn unexpected behavior, bug, or error

Description

@benfogle
benfogle
opened on Sep 19, 2022

Bug report

The function ssl.SSLSocket.shared_ciphers always returns the server's cipher list, rather than the ciphers common to both client and server. I.e., the same list as ssl.SSLContext.get_ciphers, in a different format.

This is due to the use of SSL_get_ciphers in the implementation, rather than SSL_get_shared_ciphers.

Your environment

  • CPython versions tested on: 3.8.10, 3.12.0a0
  • Operating system and architecture: Ubuntu 20.04, x86_64

Linked PRs

Activity

  1. benfogle
    added
    type-bugAn unexpected behavior, bug, or error
    on Sep 19, 2022
  2. ned-deily
    added
    topic-SSL
    on Sep 20, 2022
  3. Yhg1s
    added a commit that references this issue on Mar 22, 2023

    gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (#96932)

    af9c34f
  4. miss-islington
    added 2 commits that reference this issue on Mar 22, 2023

    pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…

    0c15975

    pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…

    88d3673
  5. Yhg1s
    added 2 commits that reference this issue on Mar 24, 2023

    [3.11] gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (

    e075631

    [3.10] gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (

    0a2b63f
  6. Yhg1s
    closed this as completedon Mar 24, 2023
  7. Fidget-Spinner
    added a commit that references this issue on Mar 27, 2023

    pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…

    233ef6d
  8. warsaw
    added a commit that references this issue on Apr 11, 2023

    pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…

    7c770f2
  9. stormi
    added a commit that references this issue on Feb 13, 2025

    Accomodate the test to the changed behavior of SSLContext.shared_ciph…

    c01f448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic-SSLtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions