Skip to content

main branch code cleanups for int_max_str_digits non-backportable TODOs #96512

Description

@gpshead

I had some post-merge TODOs ready in #96499 for improvements specific to the main (3.12) branch. This is a rollup issue for those, they're all small:

  • Cleanup: Move int_max_str_digits into PyConfig in 3.12.
  • Use int32_t or Py_ssize_t instead of int for the max digits value internally.
  • Minor feature: add PEP-578 PySys_Audit hook calls at the new ValueError raise spots.
  • Once this ships in 3.11.0: Update the version notes about it in the 3.12 docs to say 3.11 and remove the 3.12 whatsnew text about it. The original PR was created not knowing exactly when we'd be able to merge.

Activity

  1. added
    type-featureA feature request or enhancement
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    3.12only security fixes
    on Sep 2, 2022
  2. self-assigned this
    on Sep 2, 2022
  3. isuruf commented on Sep 18, 2022

    @isuruf
    Contributor

    Could the limit be a configuration option, so that people who build from source can configure the limit?

  4. gpshead commented on Sep 19, 2022

    @gpshead
    MemberAuthor

    Could the limit be a configuration option, so that people who build from source can configure the limit?

    Lets have that be its own issue if someone comes up with a compelling use case for it.

    My thinking in not including a configure flag to start with is that anyone who builds from source likely also carries patches to their sources so there isn't a good reason to offer a configure option. We don't want to encourage interpreters built and shipped in different environments to have different limits as that can create compatibility headaches for application and library authors potentially expanding their test matrix.

  5. added 3 commits that reference this issue on Sep 19, 2022
  6. added a commit that references this issue on Oct 3, 2022
  7. added a commit that references this issue on Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.12only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions