Repository navigation
test_sys_settrace leaked [6604, 6602, 6604] on main branch #94979
Description
Commit tested: a25a803
@kumaraditya303 ➜ /workspaces/cpython (main) $ ./python -m test -R 3:3 test_sys_settrace
0:00:00 load avg: 31.03 Run tests sequentially
0:00:00 load avg: 31.03 [1/1] test_sys_settrace
beginning 6 repetitions
123456
......
test_sys_settrace leaked [6604, 6602, 6604] references, sum=19810
test_sys_settrace leaked [1835, 1860, 1856] memory blocks, sum=5551
test_sys_settrace failed (reference leak)
== Tests result: FAILURE ==
1 test failed:
test_sys_settrace
Total duration: 1.2 sec
Tests result: FAILURE
Activity
kumaraditya303 commentedon Jul 18, 2022
cc @markshannon @pablogsal
kumaraditya303 commentedon Jul 18, 2022
Git bisect points to 2f8bff6 as first bad commit:
mdboom commentedon Jul 18, 2022
frame.setlinenostrikes again.brandtbucher commentedon Jul 18, 2022
Checking this out now.
brandtbucher commentedon Jul 18, 2022
The following three tests are leaking:
test_jump_from_except_to_finallytest_jump_out_of_bare_except_blocktest_jump_out_of_qualified_except_blockThe issue is when we jump out of an exception handler into non-exception-handling code. We skip over
POP_EXCEPT, which is supposed to cleartstate->exc_info->exc_value, the currently active exception. This exception references thousands of objects through its traceback frames.I'm not sure what a good solution is. Perhaps clearing the thread's exception state if we can detect that we're jumping out of an exception handler? I'm not sure if that's always correct (or even easy to detect). Maybe we can flag every stack between an exception handler entry and a
POP_EXCEPT?Or, just disallow jumping out of exception handlers like this?
GH-94979: Pop the exception stack when jumping out of exception handl…
pythonGH-94979: Pop the exception stack when jumping out of exception…