You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
_decimal fails to build with --with-pydebug --with-lto on GCC #94847
GH-94474 caused several buildbots with GCC to fail to compile _decimal module with --with-pydebug --with-lto option. The problem did not show up when I was testing my PR on the build bot farm. I can reproduce the issue locally with GCC 12.1.1. Build does not fail with non-debug builds. Only the combination of LTO and debug fails for me
../Modules/_decimal/libmpdec/mpdecimal.c: In function ‘exp_to_string’:
../Modules/_decimal/libmpdec/mpdecimal.c:143:1: error: inlining failed in call to ‘always_inline’ ‘mpd_word_digits’: function not considered for inlining
143 | mpd_word_digits(mpd_uint_t word)
| ^
_decimal has been broken on LTO + pydebug builds for a while. We just didn't notice because build failure was not fatal and did not cause the buildbot to break. Here is an older build run from two days ago, https://buildbot.python.org/all/#/builders/285/builds/2550
Activity
tiran commentedon Jul 14, 2022
_decimalhas been broken on LTO + pydebug builds for a while. We just didn't notice because build failure was not fatal and did not cause the buildbot to break. Here is an older build run from two days ago, https://buildbot.python.org/all/#/builders/285/builds/2550pythongh-94847: Don't force inlining in debug builds of libmpdec
gh-94847: Don't force inlining in debug builds of libmpdec (GH-94848)
pythongh-94847: Don't force inlining in debug builds of libmpdec (pyt…
[3.11] gh-94847: Don't force inlining in debug builds of libmpdec (GH…