Repository navigation
Excess spaces at the end of files or repositorys are not handle when extracting zip files on Windows. #94018
Description
Bug report
Excess spaces at the end of files or repositorys are not handle when extracting zip files on Windows.
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Documents \\test.txt'
Can be tested with this Documents.zip
and this piece of code:
from zipfile import ZipFile
with ZipFile('Documents.zip', 'r') as zip:
zip.extractall()
Fix proposal
cpython/Lib/zipfile.py : 1690
# remove end spaces
def remove_end_spaces(x):
for c in x[::-1]:
if(c == ' '): x = x[:-1]
else: return x
arcname = (remove_end_spaces(x) for x in arcname)
Your environment
- CPython versions tested on: python 3.9
- Operating system and architecture: Windows 10 Professionnel 21H2 19044.1706
Activity
dignissimus commentedon Jun 20, 2022
Removing trailing spaces can be done using
str.rstrip.I don't think this is an issue with the zipfile library. Testing the file using unzip shows the filename as including trailing spaces and unzip extracts the file with the directory name containing the trailing spaces. I don't think this behaviour needs to be changed and I don't think it should be altered.
Testing with p7zip shows the same
Rygone commentedon Jun 20, 2022
Completely agree with the
str.rstrip.However, the problem is on Windows machines.
Windows Explorer extracts them without spaces at the end because it is not possible to have files or repositorys that end with spaces on Windows.
That's why I propose to make the change in
_sanitize_windows_name().And it's already done for dots :1688
So new proposal
cpython/Lib/zipfile.py : 1687
dignissimus commentedon Jun 20, 2022
Ok, if it causes errors on Windows then updating the sanitisation function for windows sounds very reasonable
pythongh-94018: Remove trailing spaces in _sanitize_windows_name (pyt…
pythongh-94018: Remove trailing spaces in _sanitize_windows_name (pyt…