Skip to content

tests still rely on the removed stdlib modules asyncore/asynchat #93243

Description

@arhadthedev

Reference: PEP 594 – Removing dead batteries from the standard library.

This issue tracks removal of the following modules:

Related issues:

Activity

  1. JelleZijlstra commented on May 26, 2022

    @JelleZijlstra
    Member

    This requires finishing #1864 (which I need to get back to).

  2. arhadthedev commented on Jul 12, 2022

    @arhadthedev
    MemberAuthor

    Asyncore-based test servers from test_ftp and test_logging cannot be ported to asyncio, the tested clients are blocking. However, instead of writing a server thread class from scratch, it would be nice to reuse test.support.threading_helper.Server from gh-92475.

  3. added a commit that references this issue on Aug 6, 2022
  4. added a commit that references this issue on Aug 11, 2022
  5. changed the title [-]PEP 594: Process "to be removed in 3.12" part of the plan[/-] [+]tests still rely on the removed stdlib modules asyncore/asynchat[/+] on Nov 29, 2023
  6. iritkatriel commented on Nov 29, 2023

    @iritkatriel
    Member

    Changing the title to reflect what still needs to be done.

  7. vstinner commented on Feb 27, 2025

    @vstinner
    Member

    PEP 594 has been fully implemented: asyncore, asynchat and smtpd have been removed from the stdlib.

    Some tests still use asyncore, asynchat and smtpd: there is now a copy in Lib/test/support/ only for tests. While it would be nice to rewrite these tests using asyncio or threads, it seems like no one is interested to work on that.

    I suggest to close the issue as "not planned". It's ok to leave tests are they are, since tests are now reliable and stable.

  8. iritkatriel commented on Feb 27, 2025

    @iritkatriel
    Member

    I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions