Add API to allow extensions to set callback function on creation and destruction of PyCodeObject

@carljm

BPO	46898
Nosy	@carljm, @DinoV, @itamaro, @mpage

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-03-01.22:20:58.520>
labels = ['expert-C-API', 'type-feature', '3.11']
title = 'Add API to allow extensions to set callback function on creation and destruction of PyCodeObject'
updated_at = <Date 2022-03-01.22:20:58.520>
user = 'https://github.com/mpage'

bugs.python.org fields:

activity = <Date 2022-03-01.22:20:58.520>
actor = 'mpage'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['C API']
creation = <Date 2022-03-01.22:20:58.520>
creator = 'mpage'
dependencies = []
files = []
hgrepos = []
issue_num = 46898
keywords = []
message_count = 1.0
messages = ['414309']
nosy_count = 4.0
nosy_names = ['carljm', 'dino.viehland', 'itamaro', 'mpage']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46898'
versions = ['Python 3.11']

Linked PRs

CPython extensions providing optimized execution of Python bytecode (e.g. the Cinder JIT) may need to hook into the lifecycle of code objects to determine what to optimize or to free resources allocated for code objects that no longer exist. We propose adding an API to allow extensions to set callbacks that will be invoked whenever code objects are created or destroyed.

Proposed API:

typedef enum {
  PYCODE_LCEVT_CREATED,
  PYCODE_LCEVT_DESTROYED
} PyCode_LifecycleEvent;

// A callback to be called when a code object is created or about to be destroyed.
typedef void(*PyCode_LifecycleCallback)(
  PyCode_LifecycleEvent event,
  PyCodeObject* code);

void PyCode_SetLifecycleCallback(PyCode_LifecycleCallback callback);
PyCode_LifecycleCallback PyCode_GetLifecycleCallback();

In which header file would you put that? Maybe this is simple enough that you should just submit a PR?

In which header file would you put that?

would Include/cpython/code.h make sense for this API?

Maybe this is simple enough that you should just submit a PR?

hopefully yes, we intend to do that for 3.12.
does the proposed API look reasonable?

The API looks reasonable -- I'd spell LifeCycle with two capital letters (though Wikipedia seems divided on this), and I'd start the enum values with PY_CODE, similar to _PyCodeLocationInfoKind in the same file. The implementation would seem straightforward, and code objects aren't created or destroyed at a monstrous rate (it might be worth seeing if this slows down unmarshalling noticeably, but I doubt it). The callback should probably be stored in the per-interpreter state.

pythongh-91054: Add API to allow extensions to set callback function …

GH-91054: Add code object watchers API (GH-99859)

Revert "GH-91054: Add code object watchers API (GH-99859)"

@markshannon

Unfotunately, there are many buildbots failing to build this PR. Check buildbot.python.org/all/#/release_status for reference

As per our buildbot policy, this PR will be reverted if the buildbot fleet is not fixed in the next 24h. @markshannon @itamaro can you please take a look?

I have opened #99976. I will close it if the issue is fixed before the deadline.

pythonGH-91054: Reset static events counts in code watchers tests

GH-91054: Reset static events counts in code watchers tests (#99978)

this issue can be closed now!

pythongh-91054: make code watcher tests resilient to other watchers

gh-91054: make code watcher tests resilient to other watchers (#107821)

pythongh-91054: make code watcher tests resilient to other watchers (p…

[3.12] gh-91054: make code watcher tests resilient to other watchers (G…

Navigation Menu

Repository navigation

Add API to allow extensions to set callback function on creation and destruction of PyCodeObject #91054

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Add API to allow extensions to set callback function on creation and destruction of PyCodeObject #91054

Description

Linked PRs

Activity

mpage commented on Mar 1, 2022

gvanrossum commented on Sep 15, 2022

itamaro commented on Sep 15, 2022

gvanrossum commented on Sep 24, 2022

pablogsal commented on Dec 3, 2022

itamaro commented on Dec 4, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions