Skip to content

DragonflyBSD fix nis module build #89337

Closed
Closed
DragonflyBSD fix nis module build#89337
Labels
3.11only security fixesOS-macbuildThe build process and cross-buildstdlibStandard Library Python modules in the Lib/ directory

Description

@devnexen
devnexen
mannequin
opened on Sep 11, 2021
BPO 45174
Nosy @brettcannon, @ronaldoussoren, @ned-deily, @serhiy-storchaka, @devnexen
PRs
  • bpo-45174: dragonflybsd fix nis module build. #28295
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-09-11.20:34:59.430>
labels = ['OS-mac', 'build', 'library', '3.11']
title = 'DragonflyBSD fix nis module build'
updated_at = <Date 2021-09-11.22:07:47.967>
user = 'https://github.com/devnexen'

    bugs.python.org fields:

    activity = <Date 2021-09-11.22:07:47.967>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'macOS']
creation = <Date 2021-09-11.20:34:59.430>
creator = 'devnexen'
dependencies = []
files = []
hgrepos = []
issue_num = 45174
keywords = []
message_count = 1.0
messages = ['401650']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'ronaldoussoren', 'ned.deily', 'serhiy.storchaka', 'devnexen']
pr_nums = ['28295']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue45174'
versions = ['Python 3.11']

    Activity

    1. devnexen
      added
      3.11only security fixes
      stdlibStandard Library Python modules in the Lib/ directory
      buildThe build process and cross-build
      on Sep 11, 2021

    2. serhiy-storchaka commented on Sep 11, 2021

      @serhiy-storchaka
      serhiy-storchaka
      on Sep 11, 2021
      Member

      The main difference between platforms is that the first argument of the foreach function is int on some platforms and unsigned long on others.

      PR 28295 fixes code not only on DragonflyBSD, but on FreeBSD and OpenBSD, where it is unsigned long. It is a bug fix which should be backported. But I afraid that it can break code on macOS. See f6067ec. I am not sure that I understand it completely.

      Are there compiler warnings when compile nismodule.c on macOS now? Does nis.cat() work on macOS now? If remove a cast to foreachfunc at line 255, will the compiler complain and how? Will nis.cat() work on macOS with PR 28295 applied?

    3. serhiy-storchaka
      added
      OS-mac
      on Sep 11, 2021
    4. ezio-melotti
      transferred this issue fromon Apr 10, 2022

    5. hugovk commented on Apr 11, 2022

      @hugovk
      hugovk
      on Apr 11, 2022
      Member

      Note the nis module is deprecated in 3.11 and set for removal in 3.13.

      See PEP 594 – Removing dead batteries from the standard library and #91217.

    6. brettcannon
      added
      OS-mac
      and removed
      OS-mac
      on Apr 11, 2022

    7. AlexWaygood commented on Apr 17, 2022

      @AlexWaygood
      AlexWaygood
      on Apr 17, 2022
      Member

      Closing this issue as per @brettcannon's guidance in #91217 (comment), given that nis is deprecated.

    8. AlexWaygood
      closed this as completedon Apr 17, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.11only security fixesOS-macbuildThe build process and cross-buildstdlibStandard Library Python modules in the Lib/ directory

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions