Repository navigation
nturl2path: drive definition #88973
Description
| BPO | 44810 |
|---|---|
| Nosy | @pfmoore, @tjguk, @zware, @zooba, @NickVeld |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2021-08-02.12:24:05.800>
labels = ['type-bug', 'OS-windows', '3.11']
title = 'nturl2path: drive definition'
updated_at = <Date 2021-08-02.13:12:06.776>
user = 'https://github.com/NickVeld'bugs.python.org fields:
activity = <Date 2021-08-02.13:12:06.776>
actor = 'NickVeld'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2021-08-02.12:24:05.800>
creator = 'NickVeld'
dependencies = []
files = []
hgrepos = []
issue_num = 44810
keywords = ['patch']
message_count = 2.0
messages = ['398761', '398764']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'NickVeld']
pr_nums = ['27552']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue44810'
versions = ['Python 3.11']
Activity
NickVeld commentedon Aug 2, 2021
Due some problem in a third-party package the
url2pathfunction fromnturl2pathgota/"https://b"(without,a,b` are just masks ) as the first and only argument.In the function there is the following code (
cpython/Lib/nturl2path.py
Line 30 in 414dcb1
mainbranch):As a result, the function decided that the file was located on the `S:` drive and returned the `S:\b` path without a warning.
To my mind, it is not right to take just the last letter as a drive letter because the returned path must be only for the specified URL and the unsupported ones must be marked as "bad" without any silent transformations.
NickVeld commentedon Aug 2, 2021
For the visualization I created a PR with a possible fix. (The link is set into the corresponding field.)
If everything is OK, I will perform all the required things like the CLA, news entry...